Skip to content

import-vm: remove username, password request params for vm import #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohityadavcloud merged 3 commits into from
Jun 14, 2024
Merged

import-vm: remove username, password request params for vm import #401

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ae0f48
import-vm: remove username, password request params for vm import
shwstppr May 24, 2024
587189a
revert
shwstppr Jun 14, 2024
dedfbae
correct revert
shwstppr Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions source/adminguide/virtual_machines/importing_unmanaging_vms.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,6 @@ those same credentials are later used for SSH authentication when the QCOW2 imag
.. parsed-literal::
- **zoneid** (Zone to which Instance will be imported)
- **host** (the host name or IP address of External Host)
Copy link
Contributor

@sureshanaparti sureshanaparti Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update the description above, indicating these are optional?

Linux user's username and password are needed for this API call

Copy link
Contributor Author

@shwstppr shwstppr Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding them even as optional right now gives any benefit as they are completely unused for listing.

Copy link
Contributor

@sureshanaparti sureshanaparti Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct @shwstppr, remove them - not required for listing

- **username** (the username of External Host for authentication)
- **password** (the password of External Host for authentication)

**Response**:

Expand Down