Fix subselect_gp2 intermittent failure due to parallel test conflict#1841
Open
gfphoenix78 wants to merge 1 commit into
Open
Fix subselect_gp2 intermittent failure due to parallel test conflict#1841gfphoenix78 wants to merge 1 commit into
gfphoenix78 wants to merge 1 commit into
Conversation
subselect_gp and subselect_gp2 run in the same parallel test group. subselect_gp dropped and recreated tables named subselect_t1/t2, which are also created by subselect_gp2. The race caused subselect_gp2's SELECT to fail with "relation does not exist" after a successful INSERT. Rename the tables in subselect_gp2 to subselect_gp2_t1/t2 to eliminate the naming conflict. Update all copies of the test across regress, singlenode_regress, vectorization, and pax_storage test suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subselect_gp and subselect_gp2 run in the same parallel test group. subselect_gp dropped and recreated tables named subselect_t1/t2, which are also created by subselect_gp2. The race caused subselect_gp2's SELECT to fail with "relation does not exist" after a successful INSERT.
Rename the tables in subselect_gp2 to subselect_gp2_t1/t2 to eliminate the naming conflict. Update all copies of the test across regress, singlenode_regress, vectorization, and pax_storage test suites.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions