Skip to content

Remove redundant return statements in UDP interconnect code #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MutableFire wants to merge 3 commits into
base: main
Choose a base branch
from
+0 −11
Open

Remove redundant return statements in UDP interconnect code #1829

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abbdea7
Enhancement: Remove redundant return statements in UDP interconnect code
MutableFire Jun 24, 2026
a31ab1c
Merge branch 'main' into returns-remove
MutableFire Jun 24, 2026
bfde4bc
FIX: Reinstate returns
MutableFire Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions contrib/interconnect/udp/ic_udpifc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,8 +1381,6 @@ addCursorIcEntry(CursorICHistoryTable *t, uint32 icId, uint32 cid)
t->count++;

elog(DEBUG2, "add icid %d cid %d status %d", p->icId, p->cid, p->status);

return;
}

/*
Expand Down Expand Up @@ -1770,7 +1768,6 @@ setupUDPListeningSocket(int *listenerSocketFd, int32 *listenerPort, int *txFamil
(errcode(ERRCODE_GP_INTERCONNECTION_ERROR),
errmsg("interconnect error: Could not set up udp listener socket"),
errdetail("%s: %m", fun)));
return;
}

/*
Expand Down Expand Up @@ -1806,8 +1803,6 @@ ic_set_pthread_sigmasks(sigset_t *old_sigs)
#else
(void) old_sigs;
#endif

return;
}

static void
Expand All @@ -1822,8 +1817,6 @@ ic_reset_pthread_sigmasks(sigset_t *sigs)
#else
(void) sigs;
#endif

return;
}

void
Expand Down Expand Up @@ -1945,7 +1938,6 @@ InitMotionUDPIFC(int *listenerSocketFd, int32 *listenerPort)
}

ic_control_info.threadCreated = true;
return;
}

void
Expand Down Expand Up @@ -4878,8 +4870,6 @@ markUDPConnInactiveIFC(MotionConn *conn)
pthread_mutex_lock(&ic_control_info.lock);
conn->stillActive = false;
pthread_mutex_unlock(&ic_control_info.lock);

return;
}

void
Expand Down Expand Up @@ -8208,7 +8198,6 @@ SendDummyPacket(void)
pg_freeaddrinfo_all(hint.ai_family, addrs);
if (sockfd != -1)
closesocket(sockfd);
return;
Comment thread
yjhjstz marked this conversation as resolved.
}

void logChunkParseDetails(MotionConn *conn, uint32 ic_instance_id)
Expand Down
Loading