[CELEBORN-2457][CIP-24] Adaptive partition write parallelism - #3843
Open
yew1eb wants to merge 1 commit into
Open
[CELEBORN-2457][CIP-24] Adaptive partition write parallelism#3843yew1eb wants to merge 1 commit into
yew1eb wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adaptive partition write parallelism (design doc: <[link]
(https://docs.google.com/document/d/1Kzn6_sEkzR4aDu2XofKBLUYxHyArSYdcYrlfZJuDBIw/edit?usp=sharing) >):
mapId % activeCount.LifecycleManagermeasures per-location fill time from retire reports and ramps parallelism towardceil(targetSplitInterval / fillTime)— closed-loop, no manual tuning. Every revive reply carries the full active set.PbChangeLocationPartitionInfo.additionalPartitions); three client-side configs, all off by default.Why are the changes needed?
A reduce partition is written through a single active location at a time, concentrating all mappers' write pressure on one point. In one of
our production jobs (one reduce partition, 26,090 mappers), 90% of task time was spent waiting on shuffle writes; with this feature, write
throughput improved from 6.33 MB/s to 649 MB/s.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
Three new client configs (
enabled/maxLocations/targetSplitInterval), disabled by default — no behavior change unless explicitly enabled. Protocol change is additive and safe for mixed old/new client and LifecycleManager versions.How was this patch tested?
PartitionLocationGroupSuiteJ,ReviveManagerSuiteJ,ShuffleClientSuiteJ,PartitionHotnessTrackerSuite,ChangePartitionManagerAdaptiveParallelismSuite,RequestLocationCallContextSuite.