[CELEBORN-2456] Fix wrong isAssignableFrom direction in Basic/Bearer authenticationSupported - #3841
Open
yew1eb wants to merge 1 commit into
Open
[CELEBORN-2456] Fix wrong isAssignableFrom direction in Basic/Bearer authenticationSupported#3841yew1eb wants to merge 1 commit into
yew1eb wants to merge 1 commit into
Conversation
…authenticationSupported The provider type check in BasicAuthenticationHandler and BearerAuthenticationHandler evaluated Class.forName(providerClass).isAssignableFrom(<SPI interface>) in the wrong direction, and its result was discarded anyway, making the check a no-op. Return the correctly-directed check result so invalid providers are rejected at startup, and fail fast in AuthenticationFilter.init when schemes are configured but no handler was registered, instead of silently serving requests without authentication.
Contributor
Author
|
Ping @turboFei |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the reversed
isAssignableFromdirection inBasicAuthenticationHandlerandBearerAuthenticationHandler(its result was also discarded, making the check a no-op), and fail fast inAuthenticationFilter.initwhen schemes are configured but no handler is registered.Why are the changes needed?
The broken check lets invalid providers pass startup validation; if the provider class cannot be loaded and it is the only configured scheme, all requests are silently served without authentication.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
Added
AuthenticationHandlerSuite