CASSANDRA-20446: Removed parsing of string for MBean creation #4548
+17
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Issue:
For MBean creation, cassandra uses
javax.management.ObjectName(String name)constructor. Due to this, string has to be parsed to extract properties.My Proposed Solution:
Use
javax.management.ObjectName(String name, Hashtable<String, String> table)constructor. Using this we skip parsing.Validation

All the
CassandraMetricsRegistryTest.javapassjmap before patch

jmap after patch

Before patch
After patch
This represents ~66% reduction in
ObjectName$Propertyinstances and a decrease in overall JMX's heap usage, and no changes to the externally visible JMX names or behavior.