CASSANDRA-20081: Add compaction type and strategy properties to compaction history #4540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jyothsnakonisa
left a comment
jyothsnakonisa
left a comment
There was a problem hiding this comment.
Left few comments.
test/unit/org/apache/cassandra/db/compaction/CompactionTaskTest.java
Outdated
Show resolved
Hide resolved
test/unit/org/apache/cassandra/db/compaction/CompactionTaskTest.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java
Outdated
Show resolved
Hide resolved
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Can you please check SystemKeyspaceMigrator41.java? specifically migrateCompactionHistory() method. You might need to include compaction_type during migration.
src/java/org/apache/cassandra/tools/nodetool/CompactionHistory.java
Outdated
Show resolved
Hide resolved
arvindKandpal-ksolves
force-pushed
the
CASSANDRA-20081-enhance-compaction-history
branch
from
21d8883 to
519ea81
Compare
Contributor
Author
|
@jyothsnakonisa Thanks for the review. I have addressed all your comments:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
nodetool compactionhistorydoes not provide visibility into the specific type of compaction (e.g., Major, Minor, Validation) or the compaction strategy used (e.g., STCS, LCS). Additionally, the output displays raw bytes by default, which is difficult to read.This patch enhances the compaction history by persisting the compaction type and strategy properties into the
system.compaction_historytable and exposing them vianodetool.Changes included in this patch:
compaction_typecolumn tosystem.compaction_history.CompactionTaskto capture the compaction type (e.g., Major, Cleanup) and strategy class (e.g., SizeTieredCompactionStrategy) and persist them.CompactionHistoryTabularDataandnodetool compactionhistoryprinter to display these new fields.nodetool compactionhistoryto display human-readable sizes (KiB, MiB) by default. Added a-n/--no-human-readableflag to revert to raw bytes.SystemKeyspaceTest,CompactionTaskTest, andCompactionHistoryTestto cover schema changes and verify the persistence of new fields.Tests Performed:
ant test -Dtest.name=SystemKeyspaceTest(PASSED)ant test -Dtest.name=CompactionTaskTest(PASSED)ant test -Dtest.name=CompactionHistoryTest(PASSED)nodetool compactionhistoryon a local node.patch by arvindKandpal-ksolves ; for CASSANDRA-20081