Skip to content

Improve tracing #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Improve tracing #4384

wants to merge 5 commits into from

Conversation

belliottsmith
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

ifesdjeen and others added 5 commits September 18, 2025 15:49
@ifesdjeen @belliottsmith
Accord: Add Rebootstrap and unsafe Bootstrap
09b5266 
To support recovering a node that has lost some of its local transaction log, introduce rebootstrap and unsafe bootstrap modes, where Accord ensures no responses are produced for transactions the node cannot be certain it had not previously answered.

patch by Benedict and Alex Petrov for CASSANDRA-20908
@belliottsmith
Lazy Virtual Tables
add004b 
Also Improve:
 - Searchable system_accord_debug.txn

patch by Benedict; reviewed by Aleksey Yeschenko for CASSANDRA-20899
@belliottsmith
- Support mutable lazy vtables and port remaining accord tables
1ccec48 
 - Integrate txn_blocked_by deadline and depth filter with execution logic, to ensure we terminate promptly and get a best effort reply
@belliottsmith
RemoteToLocalVirtualKeyspace: supporting access to all nodes' local v…
03d5e79 
…irtual tables from any node in the cluster

patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20900
@belliottsmith
Improve Tracing
fdaaba6 
 - Introduce pattern tracing, that can intercept failed or new coordinations matching various filters
 - Support additional tracing event collection modes (SAMPLE and RING)

patch by Benedict; reviewed by Alex Petrov for CASSANDRA-20911
@ifesdjeen
Copy link
Contributor

I hope this is not too confusing: as of moment of writing this, Improve Tracing (this) PR contains multiple commits, starting with rebootstrap. To make review simpler to track, I have made a separate PR where only tracing commit is displayed: belliottsmith#8 My (minor) comments are on the PR.

@ifesdjeen ifesdjeen self-requested a review September 26, 2025 09:08
ifesdjeen
ifesdjeen approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@ifesdjeen ifesdjeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as long as critical comments in belliottsmith#8 are either addressed or explained (in case my assumptions were wrong).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifesdjeen ifesdjeen ifesdjeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belliottsmith @ifesdjeen