Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-20499: add metrics about apply, fileSize and throttle to hinted handoff #4021

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

CASSANDRA-20499: add metrics about apply, fileSize and throttle to hinted handoff #4021

wants to merge 1 commit into from

Conversation

maoling
Copy link
Member

@maoling maoling commented Mar 31, 2025

smiklosovic
smiklosovic reviewed Mar 31, 2025
View reviewed changes
src/java/org/apache/cassandra/metrics/HintsServiceMetrics.java
@@ -51,6 +62,12 @@ public final class HintsServiceMetrics
.executor(ImmediateExecutor.INSTANCE)
.build(address -> Metrics.histogram(factory.createMetricName("Hint_delays-"+address.toString().replace(':', '.')), false));

public HintsServiceMetrics(HintsService hintsService)
{
hintsFileSize = Metrics.register(factory.createMetricName("HintsFileSize"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the only purpose of putting hintsService into the constructor is to get access to getTotalHintsSizeOfNode on it. We might go with parameter-less constructor instead and do HintsService.instance::getTotalHintsSizeOfNode()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smiklosovic smiklosovic smiklosovic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoling @smiklosovic