CASSJAVA-103: Quoting column identifiers in DefaultCreateIndex #2056
+34
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link: CASSJAVA-103.
In all schema builder classes (e.g.
DefaultCreateTable
), column identifiers are rendered usingCqlIdentifier.asCql(true)
method. This was not the case inDefaultCreateIndex
, which led to missing quotes in CQL statement.Result:
CREATE INDEX "bAr" ON "xY" (aB)
Expected:
CREATE INDEX "bAr" ON "xY" ("aB")
Added test in
CreateTableTest
to make sure same behaviour applies there.