Probabilistic diff to sample partitions for running diff test #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-c
reviewed
Sep 24, 2021
jyothsnakonisa
force-pushed
the
probabilistic-diff
branch
from
9aa5566 to
7b23b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probabilistic diff allows us to sample partitions randomly while running diff tests. It takes new config parameter
partition_sampling_probabilitythat ranges between (0-1) and samples partitions based on this probability. The default value for this config property is 1 which means that all the partitions will be diffed. The partitions that are selected are also based on the JobId, for a given sampling probability and JobId we always diff on same partitions.This helps in reproducing any issues that one might run into. Probabilistic diff allows us to run diff jobs on large clusters by sampling some partitions.