CAMEL-24422: docs - add the camel-docling input-source note to the 4.22 and 4.18 upgrade guides - #26013
CAMEL-24422: docs - add the camel-docling input-source note to the 4.22 and 4.18 upgrade guides#26013oscerd wants to merge 1 commit into
Conversation
…22 and 4.18 upgrade guides The camel-docling change shipped on three lines - 4.23.0, and by backport 4.22.1 and 4.18.5 - but only the 4_23 guide carried the note. The guides for every line live on main, so the 4.22.1 and 4.18.5 sections were missing a migration note for a changed default that affects them. Adds the same note to the "Upgrading from 4.22.0 to 4.22.1" and "Upgrading from 4.18.4 to 4.18.5" sections. The text applies verbatim to both lines: allowUrlSource, allowFilePathSource, inputBaseDirectory, the ungated header and typed bodies, the batch path containment and the File not found failure all behave the same there as on main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean documentation PR that adds the camel-docling input-source migration note (already present in the 4.23 guide) to the 4.22 and 4.18 upgrade guides on main. Text is verbatim from the existing note, correctly placed, and follows all AsciiDoc conventions.
Observations:
- Added text is character-for-character identical to the existing note in
camel-4x-upgrade-guide-4_23.adoc, confirming consistency across all three upgrade guides - Placement is correct: sections sit under the appropriate version upgrade headings
- PR description is thorough — explains why the verbatim wording is accurate even for the 4.18 line (the weakest backport)
📋 PR Metadata
| Aspect | Current | Suggested |
|---|---|---|
| Milestone | (none) | 4.23.0 |
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 0 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 0).
|
3 participants
Why
The camel-docling input-source change shipped on three lines — 4.23.0, and by backport 4.22.1 (#25733) and 4.18.5 (#25744) — but only
camel-4x-upgrade-guide-4_23.adoccarried the migration note.The upgrade guides for every release line live on
main, and backports deliberately carry no guide edit, so the note has to be added here for the other two lines. Without it, 4.22.1 and 4.18.5 ship a changed default with nothing in their own upgrade sections.What
Adds the same note to:
camel-4x-upgrade-guide-4_22.adoc→ Upgrading from 4.22.0 to 4.22.1camel-4x-upgrade-guide-4_18.adoc→ Upgrading from 4.18.4 to 4.18.5Documentation only, purely additive (60 insertions, 0 deletions).
Wording is verbatim on purpose
Guide notes should be worded per line, since what is true on one branch may not hold on another. I checked each claim against
camel-4.18.x— the weakest of the three, where the backport was materially adapted — and all of them hold there:allowUrlSource,allowFilePathSource,inputBaseDirectory,containBatchPathsand theFile not foundfailure are all present.The two ways 4.18.x genuinely differs — the chunking operations are absent, and the
security = "insecure:dev"marker was stripped because that branch's@UriParamhas no such attribute — are not user-facing behaviour and are not mentioned in the note, so the same text is accurate for all three lines.