Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-6766 Generated produces string now includes media types from all responses #16221

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

calleandersson
Copy link
Contributor

@calleandersson calleandersson commented Nov 11, 2024

Description

Changed the behavior to include media types from all existing responses when generating produces string. Information about previous behavior can be seen in issue 6776.

Of some reason, I wasn't able to download artifacts from https://repository.apache.org/snapshots so I have not been able to run mvn clean install -DskipTests.

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@calleandersson
Copy link
Contributor Author

calleandersson commented Nov 11, 2024

/component-test camel-rest-openapi

Result ✅ The tests passed successfully

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@davsclaus
Copy link
Contributor

@davsclaus
Copy link
Contributor

Can you fix code formatting issue in

--- a/components/camel-rest-openapi/src/test/java/org/apache/camel/component/rest/openapi/OpenApiUtilsTest.java
+++ b/components/camel-rest-openapi/src/test/java/org/apache/camel/component/rest/openapi/OpenApiUtilsTest.java

@calleandersson
Copy link
Contributor Author

Sorry, created a Camel Quarkus issue instead of a Camel issue by mistake.

Of some reason, I'm not able to connect to https://repository.apache.org at the moment which means I have not been able to run mvn clean install -DskipTests. Therefor I don't get the automatically formatting. Is there a way to execute the formatting without having to run mvn clean install?

@calleandersson
Copy link
Contributor Author

I removed the empty line mentioned here. Do I have to wait for some automatically job to see if there are some more formatting issues or could I trigger some job myself?

@davsclaus davsclaus merged commit fe4c0f3 into apache:main Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants