[CALCITE-7589] JOIN ... USING might fail with disabled type coercion#4995
Open
snuyanzin wants to merge 2 commits into
Open
[CALCITE-7589] JOIN ... USING might fail with disabled type coercion#4995snuyanzin wants to merge 2 commits into
JOIN ... USING might fail with disabled type coercion#4995snuyanzin wants to merge 2 commits into
Conversation
xiedeyantu
approved these changes
Jun 5, 2026
| RelDataType resultType = | ||
| validator().getTypeCoercion().commonTypeForBinaryComparison( | ||
| comparedTypes.get(0), comparedTypes.get(1)); | ||
| RelDataType resultType = validator.config().typeCoercionEnabled() |
Member
There was a problem hiding this comment.
Perhaps we can use like
RelDataType resultType = validator != null && validator.config().typeCoercionEnabled()
? ...
: ...;
Contributor
Author
There was a problem hiding this comment.
yeah, checker framework is also unhappy about this
I replaced it with validator() method which has embedded null check,
should be fine now
xiedeyantu
approved these changes
Jun 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7589
Changes Proposed
The PR fixes
JOIN ... USINGfor the case of disabled coercion