[CALCITE-7588] LIKE with ESCAPE symbols containing wildcards fails#4994
Open
snuyanzin wants to merge 1 commit into
Open
[CALCITE-7588] LIKE with ESCAPE symbols containing wildcards fails#4994snuyanzin wants to merge 1 commit into
LIKE with ESCAPE symbols containing wildcards fails#4994snuyanzin wants to merge 1 commit into
Conversation
davidradl
reviewed
Jun 5, 2026
| private static Pattern getWildCardPattern(char escape) { | ||
| switch (escape) { | ||
| case '%': | ||
| return Pattern.compile("_+"); |
There was a problem hiding this comment.
am I missing something - it looks like the case bodies are the wrong way round. % uses a Pattern with an underscore and underscore uses a pattern with %
Contributor
Author
There was a problem hiding this comment.
if % is escape symbol then it should not be a part of wildcard pattern
xiedeyantu
approved these changes
Jun 5, 2026
xiedeyantu
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7588
Changes Proposed
The PR fixes the behavior of
LIKEwithESCAPEcontaining wildcard symbols