Skip to content

fix: use utf-8 for test case json files#789

Open
Ghraven wants to merge 1 commit into
apache:mainfrom
Ghraven:fix/cli-template-utf8
Open

fix: use utf-8 for test case json files#789
Ghraven wants to merge 1 commit into
apache:mainfrom
Ghraven:fix/cli-template-utf8

Conversation

@Ghraven
Copy link
Copy Markdown

@Ghraven Ghraven commented May 24, 2026

Summary

  • read and write generated test-case JSON files with explicit UTF-8 encoding
  • read dynamic pytest test-case JSON fixtures with the same encoding

Before / after

Before, the CLI test-case generator and load_test_cases() relied on the platform default text encoding for JSON fixture files.
After, both paths use UTF-8 explicitly, making generated fixtures portable across non-UTF-8 locales.

Verification

  • python -m py_compile burr/cli/__main__.py burr/testing/__init__.py
  • git diff --check

@andreahlert andreahlert added the kind/bug Something is broken label May 26, 2026
Copy link
Copy Markdown
Collaborator

@andreahlert andreahlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM following #790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants