[improve] add metrics: total_entry_log_space_bytes#4507
Merged
hezhangjian merged 4 commits intoapache:masterfrom Feb 18, 2025
Merged
[improve] add metrics: total_entry_log_space_bytes#4507hezhangjian merged 4 commits intoapache:masterfrom
hezhangjian merged 4 commits intoapache:masterfrom
Conversation
liangyepianzhou
approved these changes
Feb 14, 2025
Contributor
liangyepianzhou
left a comment
There was a problem hiding this comment.
LGTM, It is also recommended to add a test
Member
|
reopen's reason: rerun failure checks |
hezhangjian
requested changes
Feb 17, 2025
Contributor
|
For the name: we sure follow current conventions in the project codebase |
Member
|
@eolivelli I didn't see |
Member
|
+1, It might be better to change total_entry_log_space_bytes to entry_log_space_bytes. |
Contributor
Author
@StevenLuMT thx, make sense. updated. |
dlg99
approved these changes
Feb 17, 2025
Contributor
|
Please fix the checkstyle error. Otherwise LGTM. |
hezhangjian
reviewed
Feb 17, 2025
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhangjian He <hezhangjian97@gmail.com>
hezhangjian
approved these changes
Feb 17, 2025
Member
|
@ethqunzhong please fix it |
Member
|
Thanks for your contribution. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
add metric
TOTAL_ENTRY_LOG_SPACE_BYTESAs a supplement to metricACTIVE_ENTRY_LOG_SPACE_BYTESThis allows us to easily analyze the proportion of valid data in the cluster entry log.
Changes
TOTAL_ENTRY_LOG_SPACE_BYTESin GarbageCollectorStats.