fix lost prometheus metric in OrderedExecutor #4374
Conversation
TakaHiR07
changed the title
|
@merlimat Could you take a look of this problem? |
ok, I would split to 2 pr. But I guess we can't change |
TakaHiR07
force-pushed
the
fix_orderExecutor_lost_some_metric
branch
from
6814b3c to
aa3ee80
Compare
TakaHiR07
changed the title
|
Thanks for your contribution. :) |
Fix [#4373](#4373) ### Motivation As shown in the issue. This is the first pr to fix the lost metric problem. And the other pr improve the metric in SingleThreadExecutor. Co-authored-by: fanjianye <[email protected]> (cherry picked from commit e5300a0)
Fix [#4373](#4373) ### Motivation As shown in the issue. This is the first pr to fix the lost metric problem. And the other pr improve the metric in SingleThreadExecutor. Co-authored-by: fanjianye <[email protected]> (cherry picked from commit e5300a0)
| @@ -391,6 +391,10 @@ protected OrderedExecutor(String baseName, int numThreads, ThreadFactory threadF | |||
| ExecutorService thread = createSingleThreadExecutor( | |||
| new ThreadFactoryBuilder().setNameFormat(name + "-" + getClass().getSimpleName() + "-" + i + "-%d") | |||
| .setThreadFactory(threadFactory).build()); | |||
| SingleThreadExecutor ste = null; | |||
| if (thread instanceof SingleThreadExecutor) { | |||
There was a problem hiding this comment.
We can registerMetrics here instead of the instanceOf check
There was a problem hiding this comment.
Do you mean that remove the check if (thread instanceof SingleThreadExecutor) directly ?
But createSingleThreadExecutor() is also triggered in OrderedScheduler. In OrderedScheduler, createSingleThreadExecutor() do not return SingleThreadExecutor, so I keep the check here.
Fix [apache#4373](apache#4373) ### Motivation As shown in the issue. This is the first pr to fix the lost metric problem. And the other pr improve the metric in SingleThreadExecutor. Co-authored-by: fanjianye <[email protected]>
Descriptions of the changes in this PR:
Fix #4373
Motivation
As shown in the issue.
This is the first pr to fix the lost metric problem. And the other pr improve the metric in SingleThreadExecutor.
Changes
If we only fix the problem but do not change the metric , the metric is as follow, the metric become visible, though the format is not same.