test: use junit assert instead of java assert statement in test #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangJian He <[email protected]>
hezhangjian
force-pushed
the
assert-tests
branch
from
16f2f86 to
ec7c6ea
Compare
jiazhai
reviewed
Apr 27, 2024
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/DaemonThreadFactory.java
Show resolved
Hide resolved
jiazhai
approved these changes
Apr 28, 2024
|
This PR can only be released in major releases because we removed DaemonThreadFactory in the util package and it may be used in other projects. |
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…he#4310) ### Motivation See apache#995 ### Changes 1. use junit assert instead of java assert statement in test 2. delete a unused util class also uses assert statement Signed-off-by: ZhangJian He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #995
Changes