Fix error stack track may expose to external user (#4223)

* fix error stack track may expose to external user * update code * fix check style (cherry picked from commit b5b5181)
apache · Mar 21, 2024 · 5959128 · 5959128
1 parent 081024a
commit 5959128
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/...ttp-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java b/...ttp-server/src/main/java/org/apache/bookkeeper/http/servlet/BookieHttpServiceServlet.java
@@ -35,7 +35,6 @@
 import org.apache.bookkeeper.http.HttpServer;
 import org.apache.bookkeeper.http.HttpServer.ApiType;
 import org.apache.bookkeeper.http.HttpServiceProvider;
-import org.apache.bookkeeper.http.service.ErrorHttpService;
 import org.apache.bookkeeper.http.service.HttpEndpointService;
 import org.apache.bookkeeper.http.service.HttpServiceRequest;
 import org.apache.bookkeeper.http.service.HttpServiceResponse;
@@ -91,16 +90,12 @@ protected void service(HttpServletRequest httpRequest, HttpServletResponse httpR
         return;
       }
       response = httpEndpointService.handle(request);
-    } catch (Throwable e) {
-      LOG.error("Error while service Bookie API request " + uri, e);
-      response = new ErrorHttpService().handle(request);
-    }
-    if (response != null) {
       httpResponse.setStatus(response.getStatusCode());
       try (Writer out = httpResponse.getWriter()) {
         out.write(response.getBody());
       }
-    } else {
+    } catch (Throwable e) {
+      LOG.error("Error while service Bookie API request {}", uri, e);
       httpResponse.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
     }
   }