Skip to content

[Go] Fix pubsubio import of removed genproto package - #40059

Open
DiezNobach wants to merge 1 commit into
apache:masterfrom
DiezNobach:fix/pubsubio-genproto-import
Open

[Go] Fix pubsubio import of removed genproto package#40059
DiezNobach wants to merge 1 commit into
apache:masterfrom
DiezNobach:fix/pubsubio-genproto-import

Conversation

@DiezNobach

Copy link
Copy Markdown

pubsubio imported google.golang.org/genproto/googleapis/pubsub/v1 just to use
PubsubMessage as a plain proto struct. Recent genproto releases dropped that
package, breaking builds for any module needing a newer genproto. The actual
read/write logic never used a gRPC client from it — it delegates to Dataflow's
native pubsub_read/write external transform.

This swaps the import for cloud.google.com/go/pubsub/v2/apiv1/pubsubpb, which is
wire-compatible (same field numbers) — no behavior change.

@DiezNobach DiezNobach changed the title Fix pubsubio import of removed genproto package [Go] Fix pubsubio import of removed genproto package Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @lostluck for label go.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: pubsubio imports google.golang.org/genproto/googleapis/pubsub/v1, which was removed from current genproto releasess

1 participant