Remove nullness suppression in TimestampCombiner - #40046
Merged
kennknowles merged 1 commit intoSep 9, 2026
Merged
Conversation
The class-level @SuppressWarnings({"nullness", "keyfor"}) on TimestampCombiner has no matching Checker Framework diagnostic. The enum has no fields, and Iterables.get(timestamps, 0) at END_OF_WINDOW.combine is preceded by checkArgument on size > 0. Compiling sdks:java:core with -PenableCheckerFramework is clean after removing the annotation, so no other changes are needed. Progress on apache#20507.
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
kennknowles
self-requested a review
September 8, 2026 19:59
kennknowles
approved these changes
Sep 9, 2026
Contributor
Author
|
@kennknowles thanks for the review and merge! Appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #20507 (sub-task of umbrella #20497).
The class-level
@SuppressWarnings({"nullness", "keyfor"})onTimestampCombinerhas no matching Checker Framework diagnostic:the enum has no fields, and
Iterables.get(timestamps, 0)inEND_OF_WINDOW.combineis preceded bycheckArgument(size > 0).Compiling
sdks:java:corewith-PenableCheckerFrameworkis cleanafter removing the annotation, so no other changes are needed.
Verified locally against
sdks:java:core:spotlessJavaCheck,checkstyleMaincompileJava -PenableCheckerFramework(clean rebuild)WindowingStrategyTranslationTest,WindowingTestThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.