Deprecate ParquetIO.withProjection (#20770) - #40043
Open
nitinware wants to merge 1 commit into
Open
Conversation
The withProjection(projectionSchema, encoderSchema) helpers on ParquetIO.Read and ParquetIO.ReadFiles duplicate functionality already available upstream via AvroReadSupport.setRequestedProjection and AvroReadSupport.setAvroReadSchema. The encoderSchema parameter is also redundant. Users should configure projection on a Hadoop Configuration and pass it via withConfiguration(...) instead. This change adds @deprecated + Javadoc pointing at the recommended upstream API. Behavior is unchanged; existing pipelines continue to compile and run. Fixes apache#20770
Contributor
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ParquetIO.Read#withProjectionandParquetIO.ReadFiles#withProjection.Both helpers duplicate functionality already available upstream via
AvroReadSupport.setRequestedProjection/AvroReadSupport.setAvroReadSchema,and the required
encoderSchemaparameter is redundant. Users can pass aconfigured Hadoop
ConfigurationviawithConfiguration(...)for the sameeffect.
This PR:
@Deprecated+ Javadoc@deprecatedon bothwithProjectionmethodspointing at the recommended API.
No behavior change; the methods still work exactly as before.
Fixes #20770
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.