Bump lower bound of google-cloud-bigtable to 2.44 - #40042
Conversation
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
I didn't know there would be an issue on pickling here. How about we just bump the lower bound of bigtable?
|
|
Sure. We can help generate the new beam image. |
4082670 to
e59a5bc
Compare
Thanks, I bumped the lower bound and removed the pickle fix |
|
LGTM!
I gave that a second thought, and I think we have to keep the old code path for now so that the internal tests would not be broken. |
fixes #30760, fixes #34990
google-cloud-bigtable 2.44 changed DirectRow and PostCommit test_bigtable_write started to fail so the driver uses 2.44 and workers still use 2.42, so pickle loses _pb_mutations
The PR fills _pb_mutations before pickle and before write so old workers can still write the rows
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.