[AURON #2392] Support Spark 4.2#2404
Open
XorSum wants to merge 2 commits into
Open
Conversation
XorSum
commented
Jul 20, 2026
Comment on lines
26
to
35
| /** | ||
| * Base test class under org.apache.spark.sql to use package-private [[SQLTestUtils]]; extends | ||
| * [[QueryTest]] for comparisons and checks. | ||
| * Base test class under org.apache.spark.sql to extends [[QueryTest]] for comparisons and checks. | ||
| * Before spark-4.1 also extends package-private [[org.apache.spark.sql.test.SQLTestUtils]]. | ||
| */ | ||
| @sparkverExcludeParents("4.2", "org.apache.spark.sql.test.SQLTestUtils") | ||
| abstract class AuronQueryTest | ||
| extends QueryTest | ||
| with SQLTestUtils | ||
| with BeforeAndAfterEach | ||
| with org.apache.spark.sql.test.SQLTestUtils | ||
| with AdaptiveSparkPlanHelper { |
Contributor
Author
There was a problem hiding this comment.
SQLTestUtils is deprecated since 4.2.0, and we should use QueryTest directly instead.
XorSum
commented
Jul 20, 2026
Comment on lines
+22
to
+23
| // org.apache.spark.internal.config.ConfigEntryWithDefaultFunction | ||
| private class ConfigEntryWithDefaultFunction[T]( |
Contributor
Author
There was a problem hiding this comment.
In the Java file SparkAuronConfiguration.java, a Scala case class ConfigEntryWithDefaultFunction is invoked. However, SPARK-55928 added a new field to ConfigEntryWithDefaultFunction, which caused a compilation failure. Therefore, I copied the code of ConfigEntryWithDefaultFunction to make Auron compile successfully.
XorSum
commented
Jul 20, 2026
| } | ||
| } | ||
|
|
||
| def verExcludeParents(c: whitebox.Context)(annottees: c.Expr[Any]*): c.Expr[Any] = { |
Contributor
Author
There was a problem hiding this comment.
This macro verExcludeParents was AI-generated by Kimi K3. All other code was written by human.
cxzl25
reviewed
Jul 20, 2026
Co-authored-by: cxzl25 <3898450+cxzl25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2392
Rationale for this change
https://spark.apache.org/releases/spark-release-4-2-0.html
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: Kimi K3ASF guidance: https://www.apache.org/legal/generative-tooling.html