GH-50336: [Release][Archery] Fix archery GitHub integration for release scripts#50337
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
Fixes Archery’s GitHub PR interaction for release automation by ensuring PR lookup includes the necessary base/head branches and by posting standard PR issue comments (not review comments) from release/verification flows.
Changes:
- Add
--base-branch/--head-branchoptions toarchery crossbow report-prand pass them intoRepo.github_pr(...)PR lookup. - Switch PR commenting to
create_issue_comment(...)(both for verify-release-candidate triggers and for report-pr job tracking comments). - Update
dev/release/03-binary-submit.shto pass base/head branches when callingarchery crossbow report-pr.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev/release/03-binary-submit.sh | Pass base/head branch args to archery crossbow report-pr for release PR tracking. |
| dev/archery/archery/crossbow/cli.py | Add base/head options to report_pr and use create_issue_comment for PR comments. |
…se scripts (#50337) ### Rationale for this change The source verification and binary verification scripts comment to the Verification PR were failing due to the last updates to archery in order to use a single dependency. ### What changes are included in this PR? Add required base and head branches to be used when looking for a PR. Use create_issue_comment on PRs instead of create_comment which tries to create a review comment which requires more arguments. ### Are these changes tested? Yes, I've tested them locally in isolation in order to add comments on the verification PR. ### Are there any user-facing changes? No * GitHub Issue: #50336 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d433ffc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
The source verification and binary verification scripts comment to the Verification PR were failing due to the last updates to archery in order to use a single dependency.
What changes are included in this PR?
Add required base and head branches to be used when looking for a PR.
Use create_issue_comment on PRs instead of create_comment which tries to create a review comment which requires more arguments.
Are these changes tested?
Yes, I've tested them locally in isolation in order to add comments on the verification PR.
Are there any user-facing changes?
No