-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Parquet] perf: Create Utf8/BinaryViewArray directly rather than via ArrayData
#9121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| pub fn into_array(self, null_buffer: Option<Buffer>, data_type: &ArrowType) -> ArrayRef { | ||
| let len = self.views.len(); | ||
| let views = Buffer::from_vec(self.views); | ||
| let views = ScalarBuffer::from(self.views); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new formulation is simpler too, which is a nice side effect
|
run benchmark arrow_reader arrow_reader_clickbench |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
Which issue does this PR close?
make_array) #9061Rationale for this change
ArrayData#9120Creating Arrays via ArrayData /
make_arrayhas overhead (at least 2 Vec allocations) compared to simply creating the arrays directlyViewArrays also have an extra Vec allocation (to hold their buffers)
What changes are included in this PR?
Update the parquet reader to create ViewArrays directly
Are these changes tested?
By CI
Are there any user-facing changes?