Fix nullif kernel
#9087
Merged
Fix nullif kernel
#9087
+136
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jan 2, 2026
| F: FnMut(u64) -> u64, | ||
| { | ||
| BooleanBuffer::from_bitwise_unary_op(left, offset_in_bits, len_in_bits, op).into_inner() | ||
| // reserve capacity and set length so we can get a typed view of u64 chunks |
Contributor
Author
There was a problem hiding this comment.
This restores the behavior to what it was prior to #8996
alamb
commented
Jan 2, 2026
| t | ||
| }) | ||
| .into_inner(); | ||
| let buffer = bitwise_unary_op_helper(right.inner(), right.offset(), len, |b| { |
Contributor
Author
There was a problem hiding this comment.
This restores the behavior to what it was prior to #8996
alamb
commented
Jan 2, 2026
| #[test] | ||
| fn nullif_fuzz() { | ||
| let mut rng = rng(); | ||
| let mut rng = StdRng::seed_from_u64(7337); |
Contributor
Author
There was a problem hiding this comment.
use fixed random seed so the test is reproducable
alamb
commented
Jan 2, 2026
| (32, 32), | ||
| (0, 0), | ||
| (32, 0), | ||
| (5, 800), |
Contributor
Author
There was a problem hiding this comment.
use larger slices that are more than 2 u64s
alamb
force-pushed
the
alamb/nullif_tests
branch
from
d4c15d6 to
9a8879d
Compare
This was referenced Jan 2, 2026
Open
Dandandan
approved these changes
Jan 4, 2026
mhilton
approved these changes
Jan 5, 2026
Contributor
Author
|
Thank you @Dandandan and @mhilton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
nullifkernel #9085Rationale for this change
Fix a regression introduced in #8996
What changes are included in this PR?
bitwise_unary_op_helpernotkernel by 50%, addBooleanBuffer::from_bitwise_unary#8996Are these changes tested
Yes
Are there any user-facing changes?
Fix (not yet released) bug