-
Notifications
You must be signed in to change notification settings - Fork 1.1k
perf: improve calculating length performance for GenericByteArray in row conversion
#9078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…n row conversion
|
run benchmark row_format |
|
🤖 |
|
🤖: Benchmark completed Details
|
Which issue does this PR close?
N/A
Rationale for this change
Making the row length calculation faster which result in faster row conversion
What changes are included in this PR?
Instead of iterating over the items in the array and getting the length from the byte slice, we use the offsets directly and zip with nulls if necessary
Are these changes tested?
Existing tests
Are there any user-facing changes?
Faster encoding
Split to 2 more PRs as the other 2 add a change to the public API
Related to: