Skip to content

Minor: Add examples to ProjectionMask documentation #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 16, 2025

Which issue does this PR close?

Rationale for this change

I had to keep reminding myself what the ProjectionMask represented, and I find examples makes it easier to understand

What changes are included in this PR?

Add some examples to doc strings

Are there any user-facing changes?

No, only internal comments

@alamb alamb marked this pull request as ready for review May 16, 2025 16:44
@alamb alamb added the documentation Improvements or additions to documentation label May 16, 2025
@github-actions github-actions bot added the parquet Changes to the parquet crate label May 16, 2025
Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra documentation, @alamb!

Copy link
Contributor

@zhuqi-lucas zhuqi-lucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alamb alamb merged commit c37f5a0 into apache:main May 19, 2025
16 checks passed
@alamb
Copy link
Contributor Author

alamb commented May 19, 2025

Thanks @mbutrovich and @zhuqi-lucas

@alamb alamb deleted the alamb/projection_mask_comments branch May 19, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants