Minor: Add a parquet row_filter test, reduce some test boiler plate #7522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbutrovich
reviewed
May 16, 2025
There was a problem hiding this comment.
Always happy to see more tests, thanks @alamb! Just a quick question from me.
Thanks @mbutrovich -- I pushed a commit with more comments explaining the expected requests |
|
Thanks again for the review @mbutrovich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
There is no test for a single predicate in a
RowFilterso I want to add test coverage.What changes are included in this PR?
TestReader::new()function to avoid a bunch of copy/pasteAre there any user-facing changes?
No, this is only test code change