Skip to content

Add ObjectStore::append #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Mar 2, 2023

Which issue does this PR close?

Part of apache/arrow-rs-object-store#181

Rationale for this change

Adds an append API to allow for appending to files where supported

What changes are included in this PR?

Are there any user-facing changes?

FYI @metesynnada @ozankabak @alamb

@github-actions github-actions bot added the object-store Object Store Interface label Mar 2, 2023
@tustvold tustvold marked this pull request as draft March 2, 2023 16:05
@tustvold
Copy link
Contributor Author

tustvold commented Mar 2, 2023

If we're happy with this interface, I can look into implementing it for LocalFileSystem

@metesynnada
Copy link
Contributor

metesynnada commented Mar 2, 2023

I agree with the API design, I made a POC on synnada-ai#4. Thanks for the effort 😀

@ozankabak
Copy link

LGTM, thanks Raphael 👍

/// * Concurrent calls to [`ObjectStore::put`] may result in data loss / corruption
/// * Concurrent calls to [`ObjectStore::append`] may result in data loss / corruption
///
/// Additionally some stores, such as Azure, may only support appending to objects created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the docstrings make a lot of sense -- thank you for spelling it out so clearly

@tustvold tustvold marked this pull request as ready for review March 2, 2023 17:04
@tustvold
Copy link
Contributor Author

tustvold commented Mar 2, 2023

Ok - I'll get this in

I made a POC on synnada-ai#4

Looks good from a quick look, if you would like to get it polished up and raise a PR here I'll give a more in-depth review

@tustvold tustvold merged commit 661bbad into apache:master Mar 2, 2023
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = 4f67296 and contender = 661bbad. 661bbad is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

metesynnada pushed a commit to synnada-ai/arrow-rs that referenced this pull request Mar 16, 2023
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants