Skip to content

Conversation

aale24
Copy link

@aale24 aale24 commented Feb 1, 2025

Fix integer overflow in apr_wait_for_io_or_timeout by performing the microseconds to milliseconds conversion before assigning to 32-bit timeout.

The timeout overflow occurs in APR's waitio.c when converting microseconds to milliseconds for poll(), where any timeout above 28 minutes and 25 seconds fails because the 32-bit integer overflows.

The proposed fix handles the conversion before assigning to the 32-bit integer, allowing timeouts up to 24.85 days to work correctly. Since poll() itself uses a 32-bit timeout parameter and practical timeouts rarely exceed days (max around 25 days), this fix handles all real-world use cases.

I reported this bug in https://bz.apache.org/bugzilla/show_bug.cgi?id=69542

Fix integer overflow in apr_wait_for_io_or_timeout by performing the microseconds to milliseconds conversion before assigning to 32-bit timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant