fix: ai-request-rewrite plugin wrong test
#12083
Conversation
dosubot
bot
added
size:S
| model_options = conf.options | ||
| } | ||
|
|
||
| local res, err, httpc = ai_driver:request(conf, request_table, extra_opts) |
There was a problem hiding this comment.
No need to manully close according to the docs
https://github.com/openresty/lua-nginx-module#tcpsockclose
There was a problem hiding this comment.
https://github.com/apache/apisix/blob/master/apisix/plugins/ai-drivers/openai-base.lua#L131
It seems that only two parameters were returned, why didn't painc occur before?
There was a problem hiding this comment.
I think at least one pass case is needed, and there should be no error level logs.
There was a problem hiding this comment.
https://github.com/apache/apisix/blob/master/apisix/plugins/ai-drivers/openai-base.lua#L131
It seems that only two parameters were returned, why didn't painc occur before?
This issue occurred because when I started development and created my branch, the function was returning three parameters. After this PR was merged: https://github.com/apache/apisix/pull/12030/files#diff-b9bb0990d3ea842c42b094837737acfb597e2c8bf3a976dda8be56c84ef5b3c0L109, the returned parameters were adjusted. The code in my branch hasn't been synchronized with upstream, which caused this inconsistency.
I think at least one pass case is needed, and there should be no error level logs.
The test cases are already covered, and the tests cannot pass without making this change.
dosubot
bot
added
size:M
LiteSun
changed the title
LiteSun
changed the title
ai-request-rewrite plugin wrong test
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
github-project-automation
bot
moved this from 📋 Backlog
to ✅ Done
in ⚡️ Apache APISIX Roadmap
Description
In the ai-request-rewrite2.ts file, the TEST 3 case was incorrectly configured with the wrong plugin. It has now been corrected.
deepend on #12101
Fixes # (issue)
Checklist