-
Notifications
You must be signed in to change notification settings - Fork 2.6k
docs: add troubleshooting option for openid-connect #11892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This solved my issue when nothing else did. Signed-off-by: Yarden Shoham <[email protected]>
bearer_only: false | ||
# this comes from https://github.com/zmartzone/lua-resty-openidc, if this is missing, all information will be stored in the session. This | ||
# causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token. | ||
# We currently include only access_token in the session. If this gets too big we can remove it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you simplify the comment to
# use session_contents option to configure which information among id_token, user, enc_id_token, and access_token, get stored.
and add the same doc update to the Chinese doc?
# causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token. | ||
# We currently include only access_token in the session. If this gets too big we can remove it as well. | ||
session_contents: | ||
access_token: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is an attribute that was previously not explicitly exposed, so should be also be added to attribute section of the doc; as well as to the plugin schema in the source code (relevant tests need to be updated as well) 💭 cc: @juzhiyuan
Maybe you could take over and do everything in #11889 |
Ok I will evaluate and update accordingly |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
I'm including this info in the other doc PR now, thanks. |
This solved my issue when nothing else did.
References #11711