feat: Allow proxy_cache zones to be configured from values.yaml#802
feat: Allow proxy_cache zones to be configured from values.yaml#802brmejia wants to merge 7 commits into
Conversation
|
Could someone give feedback or review this PR? |
|
This would be a very nice feature! Currently it seems we need to overwrite the whole |
6d9a3aa to
7d459c1
Compare
Baoyuantop
left a comment
There was a problem hiding this comment.
Thanks for working on this feature. The direction is useful because it turns the #667 workaround into an explicit values.yaml entry.
I do not think this is ready to merge yet. There are two points that should be addressed first:
-
The new schema is added as a top-level
proxy_cache, while the actual template and docs useapisix.proxy_cache.zones. That means the schema does not validate the values path users will actually configure. Please either move the schema to the real values path or explain the current schema structure and add validation evidence. -
This PR changes APISIX startup config rendering, but I do not see a
helm template/chart-testing case showing a customproxy_cache.zonesentry rendered correctly. Please add a minimal rendering verification coveringname/memory_sizeand the optional disk/cache_levels fields.
Also, the toYaml -> fromYaml -> len check in the template is not very clear for a list value. Using with or checking the list length directly would be easier to maintain.
This PR add missing functionality reported here #667
Additional proxy_cache zones can be defined using values.yaml like this: