-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: support merging tag #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
First of all, thanks for the contribution. And I found an error.
UPDATE `tag_rel` SET `tag_id` = ?, `updated_at` = ? WHERE (tag_id = ?) AND (object_id LIKE ?) AND object_id NOT IN (SELECT object_id FROM tag_rel WHERE tag_id=? AND object_id LIKE ?) [10030000000003699 2025-04-23 11:13:03 10030000000003701 1001% 10030000000003699 1001%] - 1.244208ms
Deleting it may be a good choice. This keeps behaviour consistent. For example questions. init state: questions1(t1, t2, t3), question2(t2)
The merged behaviour is the same in question 1 and question 2. |
Thanks @LinkinStars for these suggestions! Does the error happened on MySQL? I've verified with SQLite. Anyway, I'll validated for both databases. BTW, I'm kind of busy recently, will update based on your suggestions later. Thanks! |
You've done a great job 👍. So, take your time. It's a big feature that we're continuing to test as well. |
… remove unused code
Close #1110 .
Process when merging one tag to another.
tag.follow
actiontag_id
to target tag id intag_rel
table when all below conditions mettag_id
equals source tag idobject_id
is withquestion
prefix, which is1001
Test cases validated