Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMBARI-26307: Knox SSO fails to login into Ambari #3941

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

prabhjyotsingh
Copy link
Contributor

@prabhjyotsingh prabhjyotsingh commented Feb 5, 2025

What changes were proposed in this pull request?

Fix getAuthenticated method when Knox SSO is enabled.
I believe this started happening after the jQuery upgrade.

How was this patch tested?

Have installed Knox in one of the hosts, then setup Knox SSO for Ambari (ambari-server setup-sso).
Once everything is configured/restarted check if we are able to login using knox-sso (hadoop-jwt) or not.

And without this patch UI errors out with

Uncaught TypeError: xhr.getResponseHeader is not a function
    at Class.<anonymous> (app.js:92484:24)
    at c (vendor.js:1717:25)
    at Object.fireWith [as resolveWith] (vendor.js:1772:20)
    at l (vendor.js:4936:19)
    at XMLHttpRequest.<anonymous> (vendor.js:5085:23)

@basapuram-kumar
Copy link
Contributor

LGTM

@JiaLiangC
Copy link
Contributor

@zRains Could you help review this?

ambari-web/app/router.js Show resolved Hide resolved
Copy link
Contributor

@zRains zRains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JiaLiangC JiaLiangC merged commit 7cc99b9 into apache:trunk Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants