AMBARI-26306: Bumpup logback to 1.5.16(latest) due to CVE's #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@arshadmohammad , @virajjasani , @jojochuang |
jojochuang
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
According to the logback release note CVE-2024-12801 concerns about SaxEventRecorder
CVE-2024-12798 for JaninoEventEvaluator.
Neither of them is used by Ambari. So there should be no impact.
1.2.x is no longer maintained so it's good to update it.
BTW, there're actually two test failures. But they were skipped anyway. Though they look unrelated to this change.
https://ci-hadoop.apache.org/blue/organizations/jenkins/Ambari%2FAmbari-PreCommit-GitHub-PR/detail/PR-3940/2/pipeline
JiaLiangC
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade the logback version to fix the CVE's
Details are added at AMBARI-26306