[v3-2-test] Fix millisecond floating point duration bug (#66560)#66915
Merged
Conversation
* Fix millisecond floating point duration bug Co-authored-by: hojeong park <parkhj062@gmail.com> (cherry picked from commit 52098c2)
vatsrahul1001
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66560 for the Airflow 3.2.2 patch release.
Conflict resolution
One conflict in `datetimeUtils.test.ts`. v3-2-test asserted `"00:00:10.000"` (ms precision); PR removes ms from the format and asserts `"00:00:10"`. Took PR side for the assertions (matches the production fix in `datetimeUtils.ts` that auto-merged). Preserved v3-2-test's `// eslint-disable-next-line unicorn/no-null` comment above the `null` argument since the underlying `unicorn/no-null` rule still flags the call on v3-2-test.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines