[v3-2-test] Fix DagVersion when clearing tasks with run on latest version (#65835)#66901
Merged
Conversation
* Fix DagVersion when clearing tasks with run on latest version * UI: Merge two useEffects in ClearGroupTaskInstanceDialog * UI: Add spacing between clear task checkboxes * UI: Share run on latest version logic for clear dialogs * UI: Merge two useEffects in ClearTaskInstanceDialog * Fix CI: apply pre-commit auto-fixes (cherry picked from commit 8c43743)
vatsrahul1001
requested review from
XD-DENG,
ashb,
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #65835
Conflict resolution
One conflict in
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx. Took the PR side — the PR replaces v3-2-test's simpler bundle-version comparison with the newgetRunOnLatestVersionStatehelper introduced by this same PR (in the newrunOnLatestVersion.tsfile), plus auseEffectto manage therunOnLatestVersionstate.Lint fix-up
@typescript-eslint/no-unnecessary-conditionflagged twotaskInstance?.dag_version?...optional chains as unnecessary sincetaskInstanceis typed non-nullish onv3-2-test. Changed them totaskInstance.dag_version?....Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines