Keep Named*Logger.name working across structlog releases#66875
Open
ashb wants to merge 1 commit into
Open
Conversation
ashb
added
the
backport-to-v3-2-test
eladkal
approved these changes
May 13, 2026
amoghrajesh
approved these changes
May 13, 2026
phanikumv
approved these changes
May 13, 2026
A pre-emptive change to support - structlog 26.1.0 (most likely version - merged in hynek/structlog#786) adds a `name` slot and a kwarg-only `name` argument to `BytesLogger`, and its `__init__` now assigns `self.name = name`. In NamedBytesLogger we were setting `self.name` *before* calling `super().__init__`, so on the new release the parent would overwrite the caller-supplied name with `None`, breaking the per-logger level lookup in `make_filtering_logger` and any other consumer that reads `logger.name`. Since this is not yet released, I can't be certain if it will be in 26.1.0 or something else, but it's merged to structlog's main, so lets cope with it when ever it lands.
ashb
force-pushed
the
structlog-bytes-logger-compat
branch
from
7f44bc2 to
ffade0c
Compare
Lee-W
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-emptive change to support - structlog 26.1.0 (most likely version - merged in hynek/structlog#786) adds a
nameslot and a kwarg-onlynameargument toBytesLogger, and its__init__now assignsself.name = name.In NamedBytesLogger we were setting
self.namebefore callingsuper().__init__, so on the new release the parent would overwrite thecaller-supplied name with
None, breaking the per-logger level lookup inmake_filtering_loggerand any other consumer that readslogger.name.Since this is ont yet released, I can't be certain if it will be in 26.1.0 or
something else, but it's merged to structlog's main, so lets cope with it
when ever it lands
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.