Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/registry-backfill.yml
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,21 @@ jobs:
aws-secret-access-key: ${{ secrets.DOCS_AWS_SECRET_ACCESS_KEY }}
aws-region: us-east-2

- name: "Download providers.json from S3"
env:
S3_BUCKET: ${{ needs.prepare.outputs.bucket }}
run: |
# `breeze registry publish-versions` calls publish_registry_versions.py,
# which reads providers.json (lines 119-127) to know which provider
# IDs to iterate. The job runs in a fresh checkout where providers.json
# is gitignored, so without this step the publish raises FileNotFoundError.
# Download to dev/registry/ -- the function's inline path fallback
# resolves the file from there.
mkdir -p dev/registry
aws s3 cp \
"${S3_BUCKET}api/providers.json" \
dev/registry/providers.json

- name: "Publish version metadata"
env:
S3_BUCKET: ${{ needs.prepare.outputs.bucket }}
Expand Down
26 changes: 26 additions & 0 deletions dev/breeze/tests/test_publish_registry_versions.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,3 +250,29 @@ def test_missing_providers_json_raises(self, tmp_path):
"s3://staging-docs-airflow-apache-org/registry/",
providers_json_path=tmp_path / "nonexistent.json",
)

def test_inline_fallback_to_dev_registry_providers_json(self, tmp_path, monkeypatch):
"""publish_versions resolves providers.json from dev/registry/ when
registry/src/_data/providers.json is absent.

The Registry Backfill workflow's ``publish-versions`` job runs in a
fresh checkout where providers.json is gitignored, so it downloads
the file to ``dev/registry/providers.json``. Without this fallback,
the publish step would raise FileNotFoundError.
"""
monkeypatch.chdir(tmp_path)
# registry/src/_data/providers.json deliberately absent
(tmp_path / "dev" / "registry").mkdir(parents=True)
(tmp_path / "dev" / "registry" / "providers.json").write_text(json.dumps({"providers": []}))

client = MagicMock()
client.get_paginator.return_value.paginate.return_value = []
with (
patch(
"airflow_breeze.utils.publish_registry_versions.boto3.client",
return_value=client,
),
patch("airflow_breeze.utils.publish_registry_versions.invalidate_cloudfront"),
):
# Empty providers list -> no per-provider work, returns cleanly.
publish_versions("s3://staging-docs-airflow-apache-org/registry/")
Loading