UI: Filter task instances by rendered map index#66008
Open
pierrejeambrun wants to merge 3 commits into
Open
Conversation
pierrejeambrun
requested review from
XD-DENG,
ashb,
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:API
pierrejeambrun
force-pushed
the
feature/search-rendered-map-index
branch
from
1ddd474 to
8658f05
Compare
pierrejeambrun
commented
Apr 28, 2026
| ], | ||
| ) | ||
| @conf_vars({("api", "maximum_page_limit"): "110"}) | ||
| def test_rendered_map_index_order( |
Member
Author
There was a problem hiding this comment.
Not needed anymore. WIth the hybrid expression part, now defaults to 'map_index' if null. Won't be null for mapped indexes, this test isn't relevant. (testing null ordering, but the field isn't null anymore) Can remain null for non mapped TI
pierrejeambrun
force-pushed
the
feature/search-rendered-map-index
branch
from
fbc83c1 to
7c5350e
Compare
bbovenzi
added
the
backport-to-v3-2-test
Contributor
|
Rendered Map Index seems to be searching by the index number but not the rendered string. 
|
Member
Author
|
Similarly to the 'map_index' this is an But since it's a string it probably makes more sense. Let me update that, it was my first draft but moved away from it for consistency. |
pierrejeambrun
force-pushed
the
feature/search-rendered-map-index
branch
from
7c5350e to
d00d73b
Compare
bbovenzi
approved these changes
Apr 30, 2026
Contributor
|
Merge conflicts and MySQL test failure |
Contributor
|
@pierrejeambrun can you resolve conflicts and look into failing test? |
bbovenzi
force-pushed
the
feature/search-rendered-map-index
branch
from
d00d73b to
232d27c
Compare
Adds 'rendered_map_index_pattern' (substring match) and 'rendered_map_index_prefix_pattern' (index-friendly prefix match) query parameters to the public listMapped and listTaskInstances endpoints, mirroring the existing 'operator_name', 'pool_name', etc. pattern/prefix-pattern pairs. The UI surfaces this as a search input in the TaskInstances filter bar — prefix search by default, with an 'advanced search' toggle to switch to substring match. The TaskInstance.rendered_map_index hybrid_property now has a SQL-level .expression so queries see the same value as the API response: the explicit _rendered_map_index when set, otherwise str(map_index). Without this, filtering on rendered map index silently dropped rows whose _rendered_map_index column is NULL but whose displayed value is the numeric map index. Closes apache#51820.
bbovenzi
force-pushed
the
feature/search-rendered-map-index
branch
from
63cd8d5 to
da85d11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51820.
Adds a
rendered_map_indexexact-match filter (list-of-strings,ANY_EQUAL) to the publiclistMappedandlistTaskInstancesendpoints, mirroring the existingmap_indexfilter, and surfaces it in the Task Instances filter bar in the UI. Users can now find a dynamically mapped task by the named mapping that's already shown in the column — no more "search by what you see" gap.Test plan
pytest test_task_instances.py -k rendered_map_index_filter)?rendered_map_index=1now returns the row whose_rendered_map_indexis NULL.Screen.Recording.2026-04-30.at.16.02.11.mov
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines