Skip to content

Improve creation of RuntimeTaskInstance in TriggerRunner regarding start_for_trigger functionality#64298

Merged
dabla merged 10 commits into
apache:mainfrom
dabla:feature/improve-runtime-ti-creation-triggerer
Mar 28, 2026
Merged

Improve creation of RuntimeTaskInstance in TriggerRunner regarding start_for_trigger functionality#64298
dabla merged 10 commits into
apache:mainfrom
dabla:feature/improve-runtime-ti-creation-triggerer

Conversation

@dabla
Copy link
Copy Markdown
Contributor

@dabla dabla commented Mar 27, 2026

Improve creation of RuntimeTaskInstance in TriggerRunner regarding start_for_trigger functionality which was re-enabled via #55068.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl jscheffl added this to the Airflow 3.2.0 milestone Mar 28, 2026
@jscheffl
Copy link
Copy Markdown
Contributor

As this is a fixup from the other PR propose to add this to 3.2.0 scope FYI @vatsrahul1001

@dabla dabla merged commit 6542fe6 into apache:main Mar 28, 2026
81 checks passed
@vatsrahul1001
Copy link
Copy Markdown
Contributor

As this is a fixup from the other PR propose to add this to 3.2.0 scope FYI @vatsrahul1001

#55068 is set with milestone 3.2.1 already moving this to 3.2.1

@dabla
Copy link
Copy Markdown
Contributor Author

dabla commented Mar 29, 2026

As this is a fixup from the other PR propose to add this to 3.2.0 scope FYI @vatsrahul1001

#55068 is set with milestone 3.2.1 already moving this to 3.2.1

Thanks Rahul

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Mar 30, 2026
…art_for_trigger functionality (apache#64298)

* refactor: Extracted inner create_runtime_ti method and also create ti_context_from_server

* refactor: Added logging statement when start from trigger is enabled

* refactor: Fixed increment of try_number in defer_task method + added unit tests

* refactor: Ensure start_date is set before using it in timeout calculations

* refactor: Reformatted create_runtime_ti

* refactor: Removed unused import of DRDataModel in execute_dag_callbacks due to introduction of dag_run_data property which encapsulates this logic

* refactor: Reformatted test_defer_task_try_number_increment_on_state

* refactor: Reformatted test_defer_task_try_number_increment_on_state
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…art_for_trigger functionality (apache#64298)

* refactor: Extracted inner create_runtime_ti method and also create ti_context_from_server

* refactor: Added logging statement when start from trigger is enabled

* refactor: Fixed increment of try_number in defer_task method + added unit tests

* refactor: Ensure start_date is set before using it in timeout calculations

* refactor: Reformatted create_runtime_ti

* refactor: Removed unused import of DRDataModel in execute_dag_callbacks due to introduction of dag_run_data property which encapsulates this logic

* refactor: Reformatted test_defer_task_try_number_increment_on_state

* refactor: Reformatted test_defer_task_try_number_increment_on_state
@vatsrahul1001
Copy link
Copy Markdown
Contributor

As discussed in issue moving this to 3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Executors-core LocalExecutor & SequentialExecutor area:Triggerer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants