Draft
Conversation
We were treating the span context manager as the span but we need to get the span from the return value from enter_context.
The @tracer.start_as_current_span decorator changes the code object of decorated functions to (*args, **kwds), which breaks kgb's signature compatibility check in the mocked_parse fixture. Update the call_fake lambda to use *args/**kwargs to match the wrapped signature. The renamed log messages ("error calling on_task_instance_success listener" etc.) cause test_listener_suppresses_exceptions to fail. Update the assertion to match the new message. The OTel integration test asserts exact span equality, but the new detail spans (parse, startup, get_template_context, etc.) now appear in the trace. Update the assertion to check key parent-child relationships rather than exact span set equality. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add spans for detailed debugging info during the task execution process