Open
Conversation
dstandish
changed the title
When a trigger runs, it now creates a span that is nested in the dag run span.
dstandish
force-pushed
the
triggerer-spans
branch
from
479b809 to
be5db31
Compare
Made-with: Cursor
- Add explicit type annotation (dict[str, str | int]) for span attributes to fix MyPy error: try_number and map_index are ints, OTel supports them - Add task_instance=None to mock triggers in test_run_inline_trigger_canceled and test_run_inline_trigger_timeout to fix AttributeError when run_trigger accesses trigger.task_instance for span creation Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a trigger runs, it now creates a span that is nested in the dag run span.