feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562
Open
bittoby wants to merge 2 commits intoapache:mainfrom
Open
feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562bittoby wants to merge 2 commits intoapache:mainfrom
bittoby wants to merge 2 commits intoapache:mainfrom
Conversation
Author
|
@choo121600 Could you please review this PR? |
…2e-improve-playwright-patterns-plugins
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
plugins.spec.tsandPluginsPage.tsto align with Playwright Best Practices.This PR improves test patterns only. It does not change test coverage or behavior.
Changes in
PluginsPage.ts:page.waitForFunction()with DOM queries with locator-basedwaitFor()nameColumnandsourceColumnas typedLocatorproperties instead of methods returningstring[]Changes in
plugins.spec.ts:not.toHaveCount(),not.toBeEmpty(),toHaveCount())related: #63429
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines