feat: Replace Playwright anti-patterns with web-first assertions in drag-list#63559
Open
bittoby wants to merge 2 commits intoapache:mainfrom
Open
feat: Replace Playwright anti-patterns with web-first assertions in drag-list#63559bittoby wants to merge 2 commits intoapache:mainfrom
bittoby wants to merge 2 commits intoapache:mainfrom
Conversation
Author
|
@choo121600 Please review this PR. Welcome to any feedback! |
bittoby
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
choo121600
reviewed
Mar 14, 2026
Member
choo121600
left a comment
choo121600
left a comment
There was a problem hiding this comment.
It looks like the static check is failing.
You might find the following guide helpful in resolving it :)
https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Playwright anti-patterns with web-first assertions in
dags-list.spec.tsandDagsPage.tsto align with Playwright best practices. No test coverage or behavior changes.waitForTimeout()calls - replaced with state-based waiting (expect().toBeVisible/Hidden/toHaveCount,waitForResponse):has-text()andlocator("text=")withgetByRole(),getByTestId(), and.filter({ hasText: })verifyDagExists,verifyCardViewVisible,verifyTableViewVisible) toPromise<void>with web-firstexpect()assertionswhileloop +waitForTimeoutpolling inverifyDagRunStatuswithexpect.poll()needsReviewFilterselector (button:has-text("Needs Review")→getByTestId("dags-needs-review-filter"))closes: #63426
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines