Delay selector init until DFPManager.start#63556
Open
uranusjr wants to merge 1 commit intoapache:mainfrom
Open
Delay selector init until DFPManager.start#63556uranusjr wants to merge 1 commit intoapache:mainfrom
uranusjr wants to merge 1 commit intoapache:mainfrom
Conversation
Some selectors do not work well in daemon mode after fork (exact reason unknown; it's CPython internal). This stub allows us to delay creating a selector until after forking and work around the issue. A stub class is created to stand in the selector attribute until the real selector is initialized. This makes Mypy happy, and also provides a slightly better error message if a contributor get things wrong accidentally in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #50038. I mostly followed #50038 (comment) but added some additional infra to make things easier to understand in the future.
I have no idea how to test this in CI.